Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ui version #2827

Merged
merged 1 commit into from
Dec 14, 2024
Merged

chore: update ui version #2827

merged 1 commit into from
Dec 14, 2024

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Dec 9, 2024

project-zot/zui#459
^ updates react version to 18.x and other related changes.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested a review from andaaron as a code owner December 9, 2024 04:57
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (0137f19) to head (0f21437).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2827   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         170      170           
  Lines       30126    30126           
=======================================
  Hits        27697    27697           
  Misses       1806     1806           
  Partials      623      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha
Copy link
Contributor Author

rchincha commented Dec 9, 2024

@andaaron how do I figure out the actual library causing the failure?
https://github.com/project-zot/zot/actions/runs/12229855456/job/34110653787?pr=2827

@andaaron
Copy link
Contributor

@andaaron how do I figure out the actual library causing the failure? https://github.com/project-zot/zot/actions/runs/12229855456/job/34110653787?pr=2827

Go to https://github.com/project-zot/zot/actions/runs/12229855456?pr=2827, download the artifact, unzip it, and check the results.

This specific failure seems to be related to The identified library react-dom, version 18.3. is vulnerable.

@rchincha rchincha requested a review from shimish2 as a code owner December 14, 2024 07:19
@rchincha rchincha force-pushed the fix-deps1 branch 3 times, most recently from 4959f0e to 5ac4d07 Compare December 14, 2024 08:16
Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
@rchincha rchincha merged commit 8f5414a into project-zot:main Dec 14, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants