Fix libprojectm4 and ui-jack compiler errors #13
Conversation
struktured
changed the title
|
I also tested projectM-pulseaudio and it had the same rendering issues. |
struktured
changed the title
struktured
changed the title
struktured
requested review from
kblaschke,
revmischa,
psperl and
Blaquewithaq
|
When I last tested the Qt app, I also had rendering errors - like a quarter of the rendering area having a strange border. I've also noticed that some OpenGL objects just vanished at random points, e.g. vertex buffer objects becoming invalid and thus causing weird/broken and invisible geometry being rendered. Didn't really spend much time to find out what was going wrong. |
|
When I updated the macOS Music plugin i noticed weird screen effects in a quarter of the screen until I added a high DPI rendering flag to something (I forget exactly what) (edit: in re: "When I last tested the Qt app, I also had rendering errors - like a quarter of the rendering area having a strange border.") |
| @@ -126,14 +126,14 @@ void QProjectMConfigDialog::saveConfig() { | |||
| // Will only keep data_dir. | |||
| auto settings = projectm_get_settings(_qprojectMWidget->qprojectM()->instance()); | |||
There was a problem hiding this comment.
Hum... projectm_get_settings() didn't make it into the 4.0 release, the whole settings struct is gone and was replaced by get/set calls.
Better try compiling against the 4.0 release or current master of libprojectM.
There was a problem hiding this comment.
I believe I am? See this output:
(base) carm@blackmage:~/projects/frontend-qt$ ldd src/ui-jack/projectM-jack |grep projectM
libprojectM.so.4 => /usr/local/lib/libprojectM.so.4 (0x00007fce9bc00000)There was a problem hiding this comment.
The .so version is about misleading as it's just counted up, and not really related to the version number. The filename of projectM 4 is different though, it's named libprojectM-4.so. The include dirs also are prefixed with a projectM-4 path.
Just try to build the Qt app against latest projectM master, making sure no libs/headers of older versions are still in you system paths.
I've seen that too, was going to look into that next. I still think this PR is better than what's in master now though. |
|
So I cleaned up some old projectm header files and now get a ton of compiler errors. Will try to fix them!! |
|
Any progress with this PR or should we better convert it to a draft? |
This compiles with ui-jack and it crashed the first time I ran it, runs fine otherwise except for some weird artifacts on a few presets. Want to test it a bit more.