Wavemode7 #457
Merged
Wavemode7 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix wavemode=7 DoubleLine
revmischa
approved these changes
Feb 8, 2021
| @@ -19,7 +19,7 @@ pm_font__DATA = fonts/Vera.ttf fonts/VeraMono.ttf | |||
| # find and install all preset files | |||
| install-data-local: | |||
| find "$(PRESETSDIR)" -type d -exec $(MKDIR_P) "$(DESTDIR)/$(pm_data_dir)/{}" \; | |||
| find "$(PRESETSDIR)" -type f -exec $(INSTALL_DATA) "{}" "$(DESTDIR)/$(pm_data_dir)/{}" \; | |||
| find "$(PRESETSDIR)" -path "$(PRESETSDIR)/tests" -prune -o -type f -exec $(INSTALL_DATA) "{}" "$(DESTDIR)/$(pm_data_dir)/{}" \; | |||
There was a problem hiding this comment.
I noticed that the test presets get copied when you do "make install". This skips the tests directory. Hmm, should probably do that on the line above as well...
As always opinions/testing appreciated!
There was a problem hiding this comment.
PS: I followed the link on this page to install winamp/milkdrop2. http://www.geisswerks.com/milkdrop/
There was a problem hiding this comment.
Hm ok I'm not an advanced find user - I guess that's doing two different things in one statement? wild
# Conflicts: # src/libprojectM/Renderer/MilkdropWaveform.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know GL very well, but this fix seems to make the double line wave render properly. I just loop through the main body of ::Draw() twice if necessary.
Added new test presets to verify.