Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECK_GL_ERROR additions #805

Closed
wants to merge 1 commit into from
Closed

CHECK_GL_ERROR additions #805

wants to merge 1 commit into from

Conversation

revmischa
Copy link
Collaborator

Maybe helpful for debugging bad GL calls

@kblaschke
Copy link
Member

Before merging and reworking this code again, I'd suggest leaving it in a branch to fix the GStreamer issues, and then implement a proper debugging API via this issue here:

#732

Thst'd save us from reworking any existing code and use a proper debug class/functionality so an outside app can properly log any errors.

@kblaschke
Copy link
Member

I guess all the GL_INVALID_ENUM errors seen were due to that uninitialized framebuffer texture being used before the first frame was drawn. This is fixed in PRs #826 and #827.

May I close this PR and postpone proper GL error checking/logging to the implementation of issue #732?

@revmischa
Copy link
Collaborator Author

Sure thing

@revmischa revmischa closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants