Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart-sass raises deprecation warning because of slash for division in _constraints.scss #2500

Closed
mjgiarlo opened this issue Nov 1, 2021 · 1 comment · Fixed by #2501
Closed

Comments

@mjgiarlo
Copy link
Member

mjgiarlo commented Nov 1, 2021

It's not clear to me that the suggested solution will work for different sass tools, so I've written up this issue in lieu of a PR. 🤷🏻

      01 DEPRECATION                                                                                                                  
      01 WARNING                                                                                                                      
      01 : Using / for division is deprecated and will be removed in Dart Sass 2.0.0.                                                 
      01                                                                                                                              
      01 Recommendation: math.div(breakpoint-max(xs), 2)                                                                              
      01                                                                                                                              
      01 More info and automated migrator: https://sass-lang.com/d/slash-div                                                          
      01                                                                                                                              
      01    ╷                                                                                                                         
      01 12 │       max-width: breakpoint-max(xs) / 2;                                                                                
      01    │                  ^^^^^^^^^^^^^^^^^^^^^^                                                                                 
      01    ╵                                                                                                                         
      01     node_modules/blacklight-frontend/app/assets/stylesheets/blacklight/_constraints.scss 12:18     @import                   
      01     node_modules/blacklight-frontend/app/assets/stylesheets/blacklight/_blacklight_base.scss 14:9  @import                   
      01     blacklight-frontend/app/assets/stylesheets/blacklight/blacklight.scss 5:9                      @import                   
      01     app/assets/stylesheets/application.scss 6:9                                                    root stylesheet           
      01                                                                                                                              
      01 DEPRECATION WARNING                                                                                                          
      01 : Using / for division is deprecated and will be removed in Dart Sass 2.0.0.                                                 
      01                                                                                                                              
      01 Recommendation: math.div(breakpoint-min(sm), 2)                                                                              
      01                                                                                                                              
      01 More info and automated migrator: https://sass-lang.com/d/slash-div     
@jrochkind
Copy link
Member

jrochkind commented Nov 1, 2021

Huh, that is odd. SASS is kind of forking?

Here is SASS's explanation of the deprecation/planned removal: https://sass-lang.com/documentation/breaking-changes/slash-div

I am wondering if the sass maintainers will consider changing their mind on this deprecation, before it is actually removed -- or maybe the currently-not-entirely-supported non-dart implementations of SASS need to add support for math.div?

jcoyne added a commit that referenced this issue Nov 1, 2021
dart-sass has deprecated division and it's replacement doesn't work with libsass, so avoid division altogether.

Fixes #2500
cbeer pushed a commit that referenced this issue Nov 1, 2021
dart-sass has deprecated division and it's replacement doesn't work with libsass, so avoid division altogether.

Fixes #2500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants