Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tether.js is not actually relevant to any blacklight_range_limit JS. Earlier pre-releases of Bootstrap 4 required tether for tooltips. But even before final Bootstrap 4.0, Bootstrap tooltips were no longer using tether, using 'popper.js' instead. twbs/bootstrap#22444 So the generated require tether (and rail gem to provide tether as a sprockets asset) are irrelevant to blacklight_range_limit. It is not necessary to replace with a "require 'popper'": * A standard generated blacklight app will already have a "require 'popper'" in it's application.js https://github.com/projectblacklight/blacklight/blob/55e748dd3465b9e2781d4def04b912fcbfb1b231/lib/generators/blacklight/assets_generator.rb#L20 * The failure mode for not having popper is graceful -- tooltips simply won't work, and you will get a line in JS console "Bootstrap's tooltips require Popper.js" Closes #97
- Loading branch information