Fix List() calls that didn't fill in revision

The watchercache requires the KVList to contain the revision
for correctness.  Without it, it can miss updates from the server.

Fix the resources that were missing the revision and panic if the
revision is missing to surface the problem in future.

libcalico-go/lib/backend/k8s/resources/ipam_affinity.go

@@ -368,7 +368,10 @@ func (c *blockAffinityClient) listV1(ctx context.Context, list model.BlockAffini
 	affinityType := list.AffinityType
 	requestedIPVersion := list.IPVersion
 
-	kvpl := &model.KVPairList{KVPairs: []*model.KVPair{}}
+	kvpl := &model.KVPairList{
+		KVPairs:  []*model.KVPair{},
+		Revision: v3list.Revision,
+	}
 	for _, i := range v3list.KVPairs {
 		v1kvp, err := c.toV1(i)
 		if err != nil {

libcalico-go/lib/backend/k8s/resources/ipam_block.go

@@ -157,7 +157,10 @@ func (c *ipamBlockClient) List(ctx context.Context, list model.ListInterface, re
 		return nil, err
 	}
 
-	kvpl := &model.KVPairList{KVPairs: []*model.KVPair{}}
+	kvpl := &model.KVPairList{
+		KVPairs:  []*model.KVPair{},
+		Revision: v3list.Revision,
+	}
 	for _, i := range v3list.KVPairs {
 		v1kvp, err := IPAMBlockV3toV1(i)
 		if err != nil {

libcalico-go/lib/backend/watchersyncer/watchercache.go

@@ -218,6 +218,10 @@ func (wc *watcherCache) resyncAndCreateWatcher(ctx context.Context) {
 			wc.finishResync()
 
 			// Store the current watch revision.  This gets updated on any new add/modified event.
+			wc.logger.Logger.WithField("revision", l.Revision).Debug("List completed.")
+			if l.Revision == "" || l.Revision == "0" {
+				wc.logger.Panic("BUG: List returned empty/zero revision.  Watch would be inconsistent.")
+			}
 			wc.currentWatchRevision = l.Revision
 
 			// Mark the resync as complete.