Fixing TLS copy error #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option `-e` was only checking that the tls dir existed, but not if it had any contents. When empty (which it is sometimes) the following `cp` call would fail. I've added a check to see if the dir exists and has something in it. There is a similar fix in the sleep loop at the end checking to see if we need to update the secrets.
caseydavenport
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have added
set -ewe have hit a couple errors. The option-ewhen we checked if the TLS assests dir existed was only checking that the dir existed, but not if it had any contents. When empty (which it is sometimes) the followingcpcall would fail. I've added a check to see if the dir exists and has something in it.There is a similar fix in the sleep loop at the end checking to see if we need to update the secrets.
Todos
Release Note