Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the import for logrus to use the updated username #159

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Update the import for logrus to use the updated username #159

merged 1 commit into from
Aug 3, 2017

Conversation

mgleung
Copy link
Contributor

@mgleung mgleung commented Jul 31, 2017 •
edited
Loading

Description

Updating the logrus import to use the new updated user name (which is lowercased). This will prevent import errors with vendoring going forward.

Requires projectcalico/libcalico-go#484

Todos

  • Tests
  • Documentation

Release Note

None required

gunjan5
gunjan5 approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@gunjan5 gunjan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures seem unrelated

robbrockbank
robbrockbank approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@robbrockbank robbrockbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is an existing failure - so merging as is.

@robbrockbank robbrockbank merged commit 353fc3d into projectcalico:master Aug 3, 2017
@mgleung mgleung deleted the update-logrus branch August 3, 2017 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbrockbank robbrockbank robbrockbank approved these changes

@gunjan5 gunjan5 gunjan5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgleung @robbrockbank @gunjan5