Merge pull request #774 from JohnL17/add_key_error_exception

fix(OIDC): raise a 401 if user is not logged in

caluma/user/tests/test_views.py

@@ -78,3 +78,17 @@ def test_authentication_view_improperly_configured(rf, settings):
     request = rf.get("/graphql", HTTP_AUTHORIZATION="Bearer Token")
     with pytest.raises(ImproperlyConfigured):
         views.AuthenticationGraphQLView.as_view()(request)
+
+
+def test_no_client_id(rf, requests_mock, settings):
+    cache.clear()
+    authentication_header = "Bearer Token"
+    userinfo = {"sub": "1"}
+    requests_mock.get(
+        settings.OIDC_USERINFO_ENDPOINT, text=json.dumps(userinfo), status_code=401
+    )
+    requests_mock.post(settings.OIDC_INTROSPECT_ENDPOINT, text=json.dumps(userinfo))
+
+    request = rf.get("/graphql", HTTP_AUTHORIZATION=authentication_header)
+    response = views.AuthenticationGraphQLView.as_view()(request)
+    assert response.status_code == status.HTTP_401_UNAUTHORIZED

caluma/user/views.py

@@ -105,6 +105,9 @@ def get_user(self, request):
                         introspect_method,
                         timeout=settings.OIDC_BEARER_TOKEN_REVALIDATION_TIME,
                     )
+                    if "client_id" not in introspection:
+                        response = HttpResponse(status=401)
+                        raise HttpError(response)
                     return models.OIDCClient(token, introspection)
                 else:
                     raise e