Fixed crash in DeskClock during monkey test. #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting below crash when running monkey test-: java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter event at com.android.deskclock.LabelDialogFragment$ImeDoneListener.onEditorAction(Unknown Source:7) event parameter is currently declared as non null. it can be null also, So declaring it as null parameter. Tracked-On: OAM-128844 Signed-off-by: Ankit Agrawal <ankit.agarwal@intel.com> Signed-off-by: Xu Bing <bing.xu@intel.com>
sysopenci
added
Pending Developer Approval
sysopenci
requested review from
balajim001,
bing8deng,
dyang23,
gkdeepa,
JeevakaPrabu,
kaushlen,
lchen43,
sgnanase,
shivasku82,
shyjumon-n,
swaroopbalan,
vilasrk,
yaoxinshi-intel,
yyao3 and
zhy1030
dyang23
approved these changes
Dec 31, 2024
sysopenci
removed request for
zhy1030,
bing8deng,
yyao3,
JeevakaPrabu,
sgnanase,
lchen43 and
gkdeepa
sysopenci
removed request for
swaroopbalan,
shyjumon-n,
balajim001,
shivasku82,
yaoxinshi-intel,
kaushlen and
vilasrk
sysopenci
added
Developer Approved
and removed
Pending Developer Approval
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
added
Engineering Build Successful
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
merged commit d603b08
into
projectceladon:celadon/u/mr0/master
41 checks passed
|
Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting below crash when running monkey test-:
java.lang.NullPointerException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter event at com.android.deskclock.LabelDialogFragment$ImeDoneListener.onEditorAction(Unknown Source:7)
event parameter is currently declared as non null. it can be null also, So declaring it as null parameter.
Tracked-On: OAM-128844