update to Gateway API v1alpha2

[skriss]

Signed-off-by: Steve Kriss krisss@vmware.com

[codecov]

Codecov Report

Merging #456 (7604780) into main (daf21ac) will decrease coverage by 3.57%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   80.26%   76.69%   -3.58%     
==========================================
  Files          29       29              
  Lines        2235     2231       -4     
==========================================
- Hits         1794     1711      -83     
- Misses        326      379      +53     
- Partials      115      141      +26     

Impacted Files	Coverage Δ
internal/equality/equality.go	71.74% <ø> (+1.26%)	⬆️
internal/operator/scheme.go	27.27% <0.00%> (ø)
internal/operator/operator.go	51.85% <20.00%> (ø)
internal/objects/clusterrole/cluster_role.go	90.17% <100.00%> (ø)
internal/status/status.go	51.35% <0.00%> (-21.63%)	⬇️
internal/objects/contour/finalizer.go	62.50% <0.00%> (-18.75%)	⬇️
internal/controller/controller.go	65.57% <0.00%> (-17.22%)	⬇️
internal/objects/rbac.go	54.76% <0.00%> (-9.53%)	⬇️
internal/objects/configmap/configmap.go	70.88% <0.00%> (-6.33%)	⬇️
internal/objects/job/job.go	76.52% <0.00%> (-5.22%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf21ac...7604780. Read the comment docs.

[skriss]

This is not passing the upgrade test and won't without some work - mainly due to #438 and a similar issue with the CRD defs themselves (since they've moved groups).

[skriss]

We can either:

• fix the upgrade test
• leave the Gateway v1alpha1 CRDs and RBAC in place until after 1.20
• ignore the test failure
• something else?

[stevesloka]

Ship it!

[skriss]

I disabled the upgrade test in the latest commit. We'll need to address #438 to avoid situations like this in the future. Once we release 1.20, we should be able to re-enable it.

I did manually test an upgrade and confirmed that Contour was upgraded properly and an Ingress continued to route properly. Note that since the Gateway API is moving to a different API group as part of v1alpha2, there is no automated upgrade of those resources from v1alpha1; users will have to manually migrate them.

[stevesloka]

I did manually test an upgrade and confirmed that Contour was upgraded properly and an Ingress continued to route properly. Note that since the Gateway API is moving to a different API group as part of v1alpha2, there is no automated upgrade of those resources from v1alpha1; users will have to manually migrate them.

I think given the alpha status of the operator this is ok. I'd say merge this and get the tests spun up from this point going forward to make sure things work.