Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inline certificate delivery #158

Closed
2 tasks
davecheney opened this issue Jan 16, 2018 · 3 comments
Closed
2 tasks

Support inline certificate delivery #158

davecheney opened this issue Jan 16, 2018 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone

Comments

@davecheney
Copy link
Contributor

When envoyproxy/envoy#1357 is closed switch from passing certificate material in /config to passing cert material in the v2.DiscoveryResponse message.

  • remove /config volume mount from the contour container.
  • send certificate data inline in v2.DiscoveryResponse.
@davecheney davecheney added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 16, 2018
@davecheney davecheney added this to the 0.4.0 milestone Jan 16, 2018
@sevein
Copy link
Contributor

sevein commented Feb 3, 2018

The issue is now closed (commit envoyproxy/envoy@01ee725 fixes it) and it's planned to be included in Envoy 1.6.0 with no due date.

@sevein
Copy link
Contributor

sevein commented Feb 5, 2018

I've made an attempt. Looking forward to hear your thoughts.

@davecheney
Copy link
Contributor Author

@sevein looks pretty good from here, wanna push the "create PR button"?

sevein added a commit to sevein/contour that referenced this issue Feb 12, 2018
Fixes projectcontour#228.

This enable us to define the contour cluster as a DNS name. I have confirmed
that `STRICT_DNS` also works when the address is an IP.

As mentioned by @davecheney before, with projectcontour#158 and projectcontour#228 fixed we should be able
to split Contour and Envoy into separate pods. Proof of concept:
https://gist.github.com/sevein/d30e1791fbc0db786884360486e70737.

Signed-off-by: Jesús García Crespo <jesus@sevein.com>
sevein added a commit to sevein/contour that referenced this issue Feb 12, 2018
Fixes projectcontour#228.

This enable us to define the contour cluster as a DNS name. I have confirmed
that `STRICT_DNS` also works when the address is an IP.

As mentioned by @davecheney before, with projectcontour#158 and projectcontour#228 fixed we should be able
to split Contour and Envoy into separate pods. Proof of concept:
https://gist.github.com/sevein/d30e1791fbc0db786884360486e70737.

Signed-off-by: Jesús García Crespo <jesus@sevein.com>
davecheney added a commit to davecheney/contour that referenced this issue Jul 6, 2018
Fixes projectcontour#158

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit to davecheney/contour that referenced this issue Jul 6, 2018
Fixes projectcontour#158

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit to davecheney/contour that referenced this issue Jul 6, 2018
Fixes projectcontour#158

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit to davecheney/contour that referenced this issue Jul 6, 2018
Fixes projectcontour#158

Signed-off-by: Dave Cheney <dave@cheney.net>
sunjayBhatia pushed a commit that referenced this issue Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants