Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPProxy CRD should be structural and have pruning enabled #1978

Closed
youngnick opened this issue Dec 3, 2019 · 1 comment · Fixed by #2916
Closed

HTTPProxy CRD should be structural and have pruning enabled #1978

youngnick opened this issue Dec 3, 2019 · 1 comment · Fixed by #2916
Assignees
@skriss
Milestone
Backlog

Comments

@youngnick
Copy link
Member

As noted in #1723 (comment), our CRDs are not structural, and can't have pruning enabled at the moment.

My latest investigation into this suggests that pruning requires (for CustomResourceDefinitions v1beta1):

This is complicated by the fact that we'll need to move to CustomResourceDefinitions v1 at some point, which requires only structural schemas, and enforces pruning by default. v1beta1 is now deprecated, as of v1.16. However, changing this will mean that Contour will require v1.16 at a minimum.

So, this issue is to record these details for now, until we are ready to mandate at least either v1.15 or v1.16 of Kubernetes.
@youngnick youngnick added this to the Backlog milestone Dec 3, 2019
@youngnick youngnick mentioned this issue Jun 2, 2020
Closed
@jpeach
Copy link
Contributor

jpeach commented Jul 9, 2020

Blocked by #2678

@skriss skriss mentioned this issue Sep 11, 2020
Closed
@skriss skriss self-assigned this Sep 16, 2020
skriss added a commit to skriss/contour that referenced this issue Sep 16, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
dd94940 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Sep 16, 2020
Merged
skriss added a commit to skriss/contour that referenced this issue Sep 17, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
8ff5859 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Sep 17, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
37dcba8 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Sep 17, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
7039d48 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Sep 18, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
d956740 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Sep 21, 2020
@skriss
examples: generate v1 CustomResourceDefinitions
3cebcc0 
Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1.

Closes projectcontour#2678
Closes projectcontour#1723
Closes projectcontour#1978
Closes projectcontour#2903
Closes projectcontour#2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Sep 21, 2020
@skriss
examples: generate v1 CustomResourceDefinitions (#2916)
20a1fe8 
examples: generate v1 CustomResourceDefinitions

Updates the Contour CustomResourceDefinition YAML files
to contain v1 resources instead of v1beta1 with preserveUnknownFields
set to false. Also adds a check on `contour serve` for non-upgraded 
CRDs, and logs a warning if found.

Closes #2678
Closes #1723
Closes #1978
Closes #2903
Closes #2527

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

examples: generate v1 CustomResourceDefinitions skriss/contour
3 participants
@jpeach @skriss @youngnick