Move the deployment YAML to kustomize #2088
Labels
area/deployment
Issues or PRs related to deployment tooling or infrastructure.
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
Comments
|
One problem the just bit me is that |
|
My first thought was to default to using the version of kustomize in kubectl, but there's no way to know what version of kubectl a user has. I think we just need to pick a version of kustomize and document it. |
|
On 11 Jan 2020, at 4:16 am, Steve Sloka ***@***.***> wrote:
My first thought was to default to using the version of kustomize in kubectl, but there's no way to know what version of kubectl a user has.
I think we just need to pick a version of kustomize and document it.
The Kustomize YAML format is versioned (in the Kubernetes API sense), but AFAICT that versioning is not granular enough to ensure the right version of the tooling.
|
4 tasks
|
This would be very helpful, Contour could expose a remote base for each release branch so that patching could target a specific release, see an example here https://github.com/stefanprodan/eks-contour-ingress/tree/master/contour |
jpeach
added
the
area/deployment
This was referenced Feb 12, 2020
Merged
jpeach
added a commit
to jpeach/contour
that referenced
this issue
Apr 27, 2020
Move the example deployment to Kustomize. This breaks the YAML documents in the example deployment into 4 components located in `config/components` - types, contour, envoy and certgen. These are all included in the default deployments, but operators have the option of creating deployments that dont't include all the components. Deployments to various Kubernetes infrastructure are in the `deployment` directory. The base deployment pulls in all the components and sets the namespace to `projectcontour`. The `kind` deployment updates the Envoy Daemonset to use a `NodePort` service, and the `aws` deployment enables TCP load balancing with PROXY protocol support. No special options are needed for `gke` as far as I know, but it is included for completeness. The traditional quickstart YAML is now located at `config/quickstary.yaml` and is just a rendering of the base deployment. The netlify redirect can't be updated until after a release because it points to a release branch. This updates projectcontour#855, projectcontour#1190, projectcontour#2088, projectcontour#2544. Signed-off-by: James Peach <jpeach@vmware.com>
jpeach
added a commit
to jpeach/contour
that referenced
this issue
Apr 27, 2020
Move the example deployment to Kustomize. This requires the `kustomize` tool, since the version of Kustomize vendored in `kubectl apply -k` is too old to support. The YAML documents in the example deployment are broken into 4 components located in `config/components` - types, contour, envoy and certgen. These are all included in the default deployments, but operators have the option of creating deployments that dont't include all the components. The `types-v1` component contains the Contour CRDs suitable for Kubernetes 1.16 or later. Deployments to various Kubernetes infrastructure are in the `deployment` directory. The base deployment pulls in all the components and sets the namespace to `projectcontour`. The `kind` deployment updates the Envoy Daemonset to use a `NodePort` service, and the `aws` deployment enables TCP load balancing with PROXY protocol support. No special options are needed for `gke` as far as I know, but it is included for completeness. The traditional quickstart YAML is now located at `config/quickstary.yaml` and is just a rendering of the base deployment. The netlify redirect can't be updated until after a release because it points to a release branch. This updates projectcontour#855, projectcontour#1190, projectcontour#2088, projectcontour#2544. Signed-off-by: James Peach <jpeach@vmware.com>
|
The Contour project currently lacks enough contributors to adequately respond to all Issues. This bot triages Issues according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
|
The Contour project currently lacks enough contributors to adequately respond to all Issues. This bot triages Issues according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current Contour deployment YAML builds from the fragments in
examples/contourand doesn't give any help to operators that need to modify the deployment in any way.If we move this across to a kustomize configuration, we have the opportunity to be able to modify the YAML for different deployment targets (e.g. AWS, GCP, Kind), as well as generate the same consolidated YAML file that we document for the Contour quickstart. Other people that deploy Contour may be able to consume the kustomize configuration if we structure it correctly.
Pros of kustomize:
Cons on kustomize:
Proof of concept: jpeach@1c575c7
Related to #1190, #2050
The text was updated successfully, but these errors were encountered: