-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual host exceeds allowed maximum length #25
Comments
Thanks for raising this issue; I knew that at some point I would have to hash the names of the various elements going into a container name; namespace, ingress name, vhost. Look's like I'll have to raise the priority on this. |
Marking as 0.2, but it might be possible to get this backported to 0.1.1. I'll see |
Fixes projectcontour#25 Envoy requires Name fields to be 60 characters or less. Rather than doing the simple thing and using hashes as UUIDs everywhere, this PR tries hard to preserve as much of the original name as possible, while progressively truncating the longest fields to stay under the 60 char limit. Signed-off-by: Dave Cheney <dave@cheney.net>
Fixes projectcontour#25 Envoy requires Name fields to be 60 characters or less. Rather than doing the simple thing and using hashes as UUIDs everywhere, this PR tries hard to preserve as much of the original name as possible, while progressively truncating the longest fields to stay under the 60 char limit. Signed-off-by: Dave Cheney <dave@cheney.net>
Fixes projectcontour#25 Envoy requires Name fields to be 60 characters or less. Rather than doing the simple thing and using hashes as UUIDs everywhere, this PR tries hard to preserve as much of the original name as possible, while progressively truncating the longest fields to stay under the 60 char limit. Signed-off-by: Dave Cheney <dave@cheney.net>
Fixes projectcontour#25 Envoy requires Name fields to be 60 characters or less. Rather than doing the simple thing and using hashes as UUIDs everywhere, this PR tries hard to preserve as much of the original name as possible, while progressively truncating the longest fields to stay under the 60 char limit. Signed-off-by: Dave Cheney <dave@cheney.net>
@ValFadeev Hello. I think I've fixed this issue and this fix will be available in the You can do this simply with
If this hasn't fixed the problem, please reopen the issue and I'll have another shot. Thanks Dave |
Thanks for your quick response, really appreciated! Moved on to the next problem :) |
timeout validation; configurable SO_PRIORITY
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Hi,
I am trying to use contour in conjunction with ingress objects for host-based routing to backend services. Here is an example of the
spec
section from the ingress definition:Contour picks it up but throws an error because the generated virtual host name turns out to be too long:
Unfortunately, I am unable to change the enforced naming convention to shorten the host names very quickly. Is there a workaround or a plan to make this configurable? What would the considerations be if the virtual host could be overridden through an annotation? Thanks!
The text was updated successfully, but these errors were encountered: