You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The httpConnectionManagerBuilder in internal/envoy/listener.go needs some love. Many of the builder commands aren't optional and should be refactored to always be present.
Additionally, we shouldn't use the same builder helper methods in the tests to validate the results, we're essentially just doing a no-op test that validates our helpers work, not that we're producing proper output to Envoy.
The httpConnectionManagerBuilder in internal/envoy/listener.go needs some love. Many of the builder commands aren't optional and should be refactored to always be present.
Additionally, we shouldn't use the same builder helper methods in the tests to validate the results, we're essentially just doing a no-op test that validates our helpers work, not that we're producing proper output to Envoy.
Originally posted by @stevesloka in #2734 (comment)
_Slack Thread: https://kubernetes.slack.com/archives/C8XRH2R4J/p1595886040392900
The text was updated successfully, but these errors were encountered: