internal/contour: ensure the http.Router filter is present #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `http.Router` filter is present whenever we build a HTTP Connection Manager. The `Router` filter is responsible for actually forwarding HTTP requests, so omitting it leads to configurations that are syntactically valid but otherwise inoperable. This fixes projectcontour#2733. Signed-off-by: James Peach <jpeach@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #2734 +/- ##
==========================================
+ Coverage 76.98% 77.03% +0.05%
==========================================
Files 72 72
Lines 5709 5722 +13
==========================================
+ Hits 4395 4408 +13
Misses 1226 1226
Partials 88 88
|
stevesloka
suggested changes
Jul 27, 2020
stevesloka
suggested changes
Jul 27, 2020
Yeh, I expect we will see more changes to this API, e.g. the |
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
…ntour#2734) Ensure that the `http.Router` filter is present whenever we build a HTTP Connection Manager. The `Router` filter is responsible for actually forwarding HTTP requests, so omitting it leads to configurations that are syntactically valid but otherwise inoperable. This fixes projectcontour#2733. Signed-off-by: James Peach <jpeach@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
http.Routerfilter is present whenever we build aHTTP Connection Manager. The
Routerfilter is responsible for actuallyforwarding HTTP requests, so omitting it leads to configurations that
are syntactically valid but otherwise inoperable.
This fixes #2733.
Signed-off-by: James Peach jpeach@vmware.com