Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide debug variants of contour container images #2789

Closed
mkilchhofer opened this issue Aug 12, 2020 · 4 comments
Closed

Provide debug variants of contour container images #2789

mkilchhofer opened this issue Aug 12, 2020 · 4 comments
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. area/tooling Issues or PRs related to project tools and automation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@mkilchhofer
Copy link

mkilchhofer commented Aug 12, 2020

Please describe the problem you have
As already mentioned (#2050 (comment)) it would be nice, if you build debug variants of your container images containing debug tools like busybox or another minimal linux distro. This would help people troubleshoot (eg. look at the configs in the empty dir, curl the envoy healthcheck API, etc.)

For inspiration, look at the guys behind fluent-bit:

Update:
We only need to talk about the contour container images. Envoy images seems to be ubuntu based.

@youngnick youngnick added area/deployment Issues or PRs related to deployment tooling or infrastructure. area/tooling Issues or PRs related to project tools and automation. labels Aug 12, 2020
@jpeach
Copy link
Contributor

jpeach commented Aug 12, 2020

Would ephemeral debug containers address similar use cases?

@youngnick youngnick added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 12, 2020
@youngnick
Copy link
Member

I think they will, but these will help for those people who don't have an up-to-date cluster, or don't want to use an alpha feature yet.

@mkilchhofer
Copy link
Author

I think they will, but these will help for those people who don't have an up-to-date cluster, or don't want to use an alpha feature yet.

Yes, exactly. There is a sentence on this page which says:

Note: The examples in this section require the EphemeralContainers feature gate enabled in your cluster and kubectl version v1.18 or later.

We can't expect that everyone has up-to-date clusters with alpha features enabled :)

@stevesloka stevesloka added the Hacktoberfest Denotes an issue ready for any "Hacktoberfest" contributor. label Oct 1, 2020
leowmjw added a commit to leowmjw/contour that referenced this issue Oct 11, 2020
leowmjw added a commit to leowmjw/contour that referenced this issue Oct 11, 2020
Signed-off-by: Michael Leow <leow@sinarproject.org>
leowmjw added a commit to leowmjw/contour that referenced this issue Oct 14, 2020
Signed-off-by: Michael Leow <leow@sinarproject.org>
@stevesloka stevesloka removed the Hacktoberfest Denotes an issue ready for any "Hacktoberfest" contributor. label Nov 5, 2020
@mkilchhofer
Copy link
Author

Closing my issue as ephemeral debug container are GA since K8s 1.25.

@mkilchhofer mkilchhofer closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. area/tooling Issues or PRs related to project tools and automation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants