Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: add Gateway.Spec.Addresses support #4235

Closed
skriss opened this issue Dec 13, 2021 · 3 comments
Closed

Gateway API: add Gateway.Spec.Addresses support #4235

skriss opened this issue Dec 13, 2021 · 3 comments
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@skriss
Copy link
Member

skriss commented Dec 13, 2021 •
edited
Loading

ref. #3828 (comment)

To support spec address, Contour should use the address when creating the Envoy service.

Blocked by #3545
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. blocked Blocked waiting on a dependency area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Dec 13, 2021
@skriss skriss mentioned this issue Dec 13, 2021
Closed
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2021
@skriss skriss removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@skriss skriss removed the blocked Blocked waiting on a dependency label Apr 1, 2022
@skriss
Copy link
Member Author

skriss commented Apr 1, 2022

This can be at least partially supported now via the provisioner, by using the first Gateway.Spec.Addresses value to populate the Envoy service's loadBalancerIP field during creation.

skriss added a commit to skriss/contour that referenced this issue Apr 1, 2022
@skriss
basic Gateway address support
72ab0ba 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Updates projectcontour#4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Apr 1, 2022
@skriss
basic Gateway address support
1d64924 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Updates projectcontour#4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Apr 1, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Apr 4, 2022
@skriss
basic Gateway address support
b87148b 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Updates projectcontour#4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Apr 6, 2022
@skriss
basic Gateway address support
6a81a7f 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Updates projectcontour#4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Apr 8, 2022
@skriss
basic Gateway address support
a2d7d02 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Updates projectcontour#4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Apr 11, 2022
skriss added a commit that referenced this issue Apr 11, 2022
@skriss
basic Gateway address support (#4443)
1e2beab 
Adds provisioner support for a single
Gateway address of type IP or hostname.
The value will be used for the Envoy
service's spec.loadBalancerIP field.

Sets the Gateway's Ready condition to false
with a reason of AddressNotAssigned if at
lease one address has been requested, but
no requested address has been assigned.

Updates #4235.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2022
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skriss