Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: set route status correctly when routes attach to specific listeners #4600

Closed
skriss opened this issue Jun 28, 2022 · 0 comments · Fixed by #4604
Closed

Gateway API: set route status correctly when routes attach to specific listeners #4600

skriss opened this issue Jun 28, 2022 · 0 comments · Fixed by #4604
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/bug Categorizes issue or PR as related to a bug.

Comments

@skriss
Copy link
Member

skriss commented Jun 28, 2022

Right now, Contour assumes that a route's parent is a Gateway, and status is set as such. However, it's possible for routes to specify that they attach to specific listeners within a Gateway, and the status should reflect attachment to that specific listener.

kubernetes-sigs/gateway-api#1237 implemented a verification of this in the upstream conformance tests and we are now failing that test.
@skriss skriss added kind/bug Categorizes issue or PR as related to a bug. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jun 28, 2022
@skriss skriss self-assigned this Jun 29, 2022
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Jun 29, 2022
skriss added a commit to skriss/contour that referenced this issue Jun 29, 2022
@skriss
Gateway API: set route parent statuses correctly
e59dcf7 
Rearranges the Gateway API DAG processor to
process each route parent ref atomically,
to enable properly setting status for each
of them.

Closes projectcontour#4600.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 29, 2022
@skriss
Gateway API: set route parent statuses correctly
b101740 
Rearranges the Gateway API DAG processor to
process each route parent ref atomically,
to enable properly setting status for each
of them.

Closes projectcontour#4600.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jun 29, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Jul 1, 2022
@skriss
Gateway API: set route parent statuses correctly
34ca7c7 
Rearranges the Gateway API DAG processor to
process each route parent ref atomically,
to enable properly setting status for each
of them.

Closes projectcontour#4600.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jul 12, 2022
@skriss
Gateway API: set route parent statuses correctly
c4fc8d0 
Rearranges the Gateway API DAG processor to
process each route parent ref atomically,
to enable properly setting status for each
of them.

Closes projectcontour#4600.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Jul 12, 2022
@skriss
Gateway API: set route parent statuses correctly (#4604)
3ab6a48 
Rearranges the Gateway API DAG processor to
process each route parent ref atomically,
to enable properly setting status for each
of them.

Closes #4600.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gateway API: set route parent statuses correctly skriss/contour
1 participant
@skriss