Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overload-max-heap field in contourconfig #5662

Closed
yangyy93 opened this issue Aug 8, 2023 · 1 comment · Fixed by #5699
Closed

Add overload-max-heap field in contourconfig #5662

yangyy93 opened this issue Aug 8, 2023 · 1 comment · Fixed by #5699
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@yangyy93
Copy link
Member

yangyy93 commented Aug 8, 2023

Please describe the problem you have
[A clear, concise, description of the problem you are facing. What is the problem that feature X would solve for you?]
I want to use Overload Manager, but contourconfig doesn’t have this field. Is it possible to add a field overload-max-heap? If this field exists when configuring the envoy-initconfig container, add the startup args --overload-max-heap

@yangyy93 yangyy93 added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Aug 8, 2023
@sunjayBhatia
Copy link
Member

This seems reasonable to add, will add the help wanted label on this

@sunjayBhatia sunjayBhatia added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/gateway-provisioner Issues or PRs related to the Gateway provisioner and removed lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-provisioner Issues or PRs related to the Gateway provisioner help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants