provisioner: add field overloadMaxHeapSize for envoy

[yangyy93]

close #5662

[codecov]

Codecov Report

Merging #5699 (5a10310) into main (55d98f7) will increase coverage by 0.00%.
Report is 24 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 5a10310 differs from pull request most recent head c3b4630. Consider uploading reports for the commit c3b4630 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5699   +/-   ##
=======================================
  Coverage   78.60%   78.60%           
=======================================
  Files         138      138           
  Lines       19155    19156    +1     
=======================================
+ Hits        15056    15057    +1     
  Misses       3812     3812           
  Partials      287      287           

Files Changed	Coverage Δ
internal/provisioner/model/model.go	92.59% <ø> (ø)
...nternal/provisioner/objects/dataplane/dataplane.go	85.78% <100.00%> (+0.03%)	⬆️

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[tsaarni]

Just a minor nit: could you change Gateway configuration program to Gateway provisioner as that has been used in the past as a prefix for changelog entries.

[yangyy93]

ok,thanks for your review.

[tsaarni]

Thank you @yangyy93, looks good to me!

The description of the parameter that you have added in your PR is so much better than my original description of the bootstrap flag here

contour/site/content/docs/main/configuration.md

Line 513 in f3f1484

| <nobr>--overload-max-heap | "" | Defines the maximum heap size in bytes until Envoy overload manager stops accepting new connections. |

If I may ask, would you mind changing site/content/docs/main/configuration.md and aligning it by using your description instead:

| <nobr>--overload-max-heap              | 0                | Defines the maximum heap memory of the envoy controlled by the overload manager. When the value is greater than 0, the overload manager is enabled, and when envoy reaches 95% of the maximum heap size, it performs a shrink heap operation. When it reaches 98% of the maximum heap size, Envoy Will stop accepting requests. |

[yangyy93]

Thank you @yangyy93, looks good to me!

The description of the parameter that you have added in your PR is so much better than my original description of the bootstrap flag here

contour/site/content/docs/main/configuration.md

Line 513 in f3f1484

| <nobr>--overload-max-heap | "" | Defines the maximum heap size in bytes until Envoy overload manager stops accepting new connections. |

If I may ask, would you mind changing site/content/docs/main/configuration.md and aligning it by using your description instead:

| <nobr>--overload-max-heap              | 0                | Defines the maximum heap memory of the envoy controlled by the overload manager. When the value is greater than 0, the overload manager is enabled, and when envoy reaches 95% of the maximum heap size, it performs a shrink heap operation. When it reaches 98% of the maximum heap size, Envoy Will stop accepting requests. |

thanks, I have updated the relevant documentation.

[github-actions]

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 14d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

• Mark this PR as fresh by commenting or pushing a commit
• Close this PR
• Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

[tsaarni]

Thank you @yangyy93!