internal/e2e: add listener e2e test skeleton #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a scaffold for LDS tests. It uses the go-control-plane api types to generate the configuration for the http connection manager. I had initially decided not to use this method inside contour/listener.go because of the barf worthy way of converting those types to a grpc struct type. For this e2e test I decided to use go-control-plane pkg's methods as a way of double checking my hand rolled proto struct, I found a few small errors which have been corrected in this PR, so it's good to double check the data structures line up. Signed-off-by: Dave Cheney <dave@cheney.net>
|
/cc @sevein |
sevein
approved these changes
Feb 7, 2018
sunjayBhatia
pushed a commit
that referenced
this pull request
Jan 30, 2023
HTTPSRoute does not exist as per [gateway API docs](https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.HTTPRoute). For HTTPS protocol, `HTTPRoute` + `spec.tls` needs to be used. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a scaffold for LDS tests. It uses the go-control-plane api
types to generate the configuration for the http connection manager. I
had initially decided not to use this method inside contour/listener.go
because of the barf worthy way of converting those types to a grpc
struct type.
For this e2e test I decided to use go-control-plane pkg's methods as a
way of double checking my hand rolled proto struct, I found a few small
errors which have been corrected in this PR, so it's good to double
check the data structures line up.