Upgrade go-control-plane / data-plane-api #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consumes the changes in envoyproxy/go-control-plane#39. - Changed Gopkg.lock to pick the latest go-control-plane. - Changed code as per the changes in the structures defined in go-control-plane. - Updated the unit tests. - Fixes issue projectcontour#225. Signed-off-by: Amarnath <vaamarnath@gmail.com>
as it is Signed-off-by: Amarnath <vaamarnath@gmail.com>
…aamarnath-master
Signed-off-by: Dave Cheney <dave@cheney.net>
Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney
force-pushed
the
fixedbugs/225
branch
from
a7dc1f1 to
999f245
Compare
Incorporate the change in DiscoveryResponse.Resources moving from a pointer to a value. Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney
force-pushed
the
fixedbugs/225
branch
from
b0a9540 to
82cfe01
Compare
Internally internal/contour works with pointers to *route.VirtualHosts, but translate them to a slice of values in the cache's Values() method. This is a holding pattern for storing native types.Any's in caches. Signed-off-by: Dave Cheney <dave@cheney.net>
Fix tests broken by the fact that Values() returning []route.VirtualHost. Signed-off-by: Dave Cheney <dave@cheney.net>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
This PR finished @vaamarnath 's work in #226 in switching to the new go-control-plane release.
There are lots of changes in here due to the upstream's move from pointers to values in many places.