Add status subresource to HTTPProxy #2496
Conversation
|
Adding as a draft PR so that we can talk about if this is a good idea; I'm pretty sure that it is, and although it's kind of a GA guarantee violation, it should be worthwhile as we do more with status. Importantly, it doesn't change any behaviour about retrieving the status, only about setting it, which only Contour should be doing. I've updated the one place we update HTTPProxy objects' status right now, but anyone else consuming HTTPProxy objects and updating their status would also need to change to using a status update instead of patching the object. I noticed this while doing research for #2495. |
|
This also limits us to Kubernetes v1.16 which is where |
|
Ah, thanks for that Steve. Subresources are available in the previous CRD versions though, I think. I will check that out. |
youngnick
force-pushed
the
status-subresource-test
branch
from
06c8e87
to
bc37cdc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
+ Coverage 76.61% 76.63% +0.01%
==========================================
Files 68 68
Lines 5513 5513
==========================================
+ Hits 4224 4225 +1
Misses 1192 1192
+ Partials 97 96 -1
Continue to review full report at Codecov.
|
|
The |
youngnick
force-pushed
the
status-subresource-test
branch
2 times, most recently
from
c63e271
to
f2ae3f4
Compare
youngnick
force-pushed
the
status-subresource-test
branch
from
f2ae3f4
to
d153ef6
Compare
youngnick
force-pushed
the
status-subresource-test
branch
from
d153ef6
to
e12ec1e
Compare
This commit enables the status subresource for HTTPProxy. This means that: - normal HTTPProxy changes that include updates to the `status` stanza will have the status updates dropped - updates to `status` can only be made using requests to the status subresource. Also changes the HTTPProxy status updating to use the status subresource, and adds RBAC for Contour to be able to update it. Having the status subresource enabled is best-practice for CRDs and will be a foundation for further status work. It also means that HTTPProxy objects no longer need to include the `status` stanza to be valid. Refactors the `k8s.UnstructuredConverter` to have FromUnstructured and ToUnstructured methods, and uses ToUnstructured where required. Updates projectcontour#2495 Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
status-subresource-test
branch
from
e12ec1e
to
9a251f1
Compare
This commit enables the status subresource for HTTPProxy.
This means that:
statusstanza will have the status updates droppedstatuscan only be made using requests to the status subresource.Also changes the HTTPProxy status updating to use the status subresource,
and adds RBAC for Contour to be able to update it.
Having the status subresource enabled is best-practice for CRDs and will be a foundation for further status work.
It also means that HTTPProxy objects no longer need to include the
statusstanza to be valid.Updates #2495
Signed-off-by: Nick Young ynick@vmware.com