Send DAG status updates via StatusUpdateHandler #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed |
youngnick
force-pushed
the
dag-status-update
branch
from
86d8355
to
7244bae
Compare
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 76.79% 76.71% -0.08%
==========================================
Files 71 71
Lines 5502 5505 +3
==========================================
- Hits 4225 4223 -2
- Misses 1190 1197 +7
+ Partials 87 85 -2
|
jpeach
approved these changes
Jun 19, 2020
cmd/contour/serve.go
Outdated
| // Now we have the statusUpdateWriter, we can create the StatusWriter, which will take the | ||
| // status updates from the DAG, and send them to the status update handler. | ||
| eventHandler.StatusClient = &k8s.StatusWriter{ | ||
| Updater: suw, |
There was a problem hiding this comment.
Nit: it would be a bit cleaner if we just called sh.Writer() where necessary, rather than having a temporary suw.
youngnick
force-pushed
the
dag-status-update
branch
2 times, most recently
from
1939d6f
to
36f62e8
Compare
Updates the DAG StatusClient to use the StatusUpdateWriter pattern. Fixes projectcontour#2560 Fixes projectcontour#2580 Fixes projectcontour#2522 We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under projectcontour#2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly. Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
dag-status-update
branch
from
36f62e8
to
203fe82
Compare
|
@youngnick I consistently hit #2522 when running contour integration tests in my kind cluster. I tried the docker image with this fix multiple times and can confirm it fixes #2522 and all the integration tests passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the DAG StatusClient to use the StatusUpdateWriter pattern.
Fixes #2560
Fixes #2580 - I think it fixes it, but I haven't been able to reproduce, even with the excellent script provided by @primeroz.
Fixes #2522 - I've confirmed this one with testing.
We should be able to remove the StatusClient eventually, but that API also needs refactoring for adding Conditions (currently under #2495), so for now I've just updated it to send updates via the StatusUpdateWriter rather than make API calls directly.
Signed-off-by: Nick Young ynick@vmware.com