Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/contour: add config file option to set stream idle timeout #2661

Merged
merged 2 commits into from
Jul 8, 2020
Merged

cmd/contour: add config file option to set stream idle timeout #2661

merged 2 commits into from
Jul 8, 2020

Conversation

skriss
Copy link
Member

@skriss skriss commented Jul 7, 2020

Signed-off-by: Steve Kriss krisss@vmware.com

updates #2225

@skriss
cmd/contour: add config file option to set stream idle timeout
528d423 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #2661 into master will increase coverage by 0.03%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
+ Coverage   76.93%   76.96%   +0.03%     
==========================================
  Files          71       71              
  Lines        5605     5618      +13     
==========================================
+ Hits         4312     4324      +12     
- Misses       1205     1206       +1     
  Partials       88       88
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)
internal/contour/listener.go 92.00% <71.42%> (-0.75%) ⬇️
cmd/contour/servecontext.go 93.49% <100.00%> (+0.05%) ⬆️
internal/envoy/listener.go 97.64% <100.00%> (+0.03%) ⬆️
internal/dag/cache.go 99.04% <0.00%> (+0.95%) ⬆️

stevesloka
stevesloka approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skriss skriss merged commit a5b6c47 into projectcontour:master Jul 8, 2020
@skriss skriss deleted the add-stream-idle-timeout branch July 8, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevesloka stevesloka stevesloka approved these changes

@jpeach jpeach Awaiting requested review from jpeach

@youngnick youngnick Awaiting requested review from youngnick

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skriss @stevesloka