Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/contour: add config file option to set max connection duration #2670

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

skriss
Copy link
Member

@skriss skriss commented Jul 8, 2020

Signed-off-by: Steve Kriss krisss@vmware.com

updates #2225

@skriss skriss added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2020
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the add-max-connection-duration branch from 146ea9e to 9044a94 Compare July 8, 2020 18:22
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2670 into master will decrease coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   76.93%   76.93%   -0.01%     
==========================================
  Files          71       71              
  Lines        5618     5631      +13     
==========================================
+ Hits         4322     4332      +10     
- Misses       1207     1209       +2     
- Partials       89       90       +1     
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)
cmd/contour/servecontext.go 93.49% <ø> (ø)
internal/contour/listener.go 91.30% <71.42%> (-0.70%) ⬇️
internal/envoy/listener.go 97.69% <100.00%> (+0.04%) ⬆️

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skriss skriss merged commit eb45c16 into projectcontour:master Jul 9, 2020
@skriss skriss deleted the add-max-connection-duration branch July 9, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants