Add conditions to HTTPProxy and TLSCertificateDelegation #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
added
the
release-note
youngnick
force-pushed
the
add-httpproxy-conditions
branch
from
b756734
to
8ce7308
Compare
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
==========================================
- Coverage 76.93% 76.90% -0.04%
==========================================
Files 72 72
Lines 5715 5715
==========================================
- Hits 4397 4395 -2
- Misses 1227 1228 +1
- Partials 91 92 +1
|
youngnick
force-pushed
the
add-httpproxy-conditions
branch
2 times, most recently
from
5b7bec3
to
b288839
Compare
jpeach
suggested changes
Jul 22, 2020
stevesloka
approved these changes
Jul 22, 2020
youngnick
force-pushed
the
add-httpproxy-conditions
branch
3 times, most recently
from
0c0ae92
to
0bbee0b
Compare
jpeach
approved these changes
Jul 23, 2020
Updates projectcontour#2495. This adds a new `DetailedCondition` type to HTTPProxy, that allows for sub-conditions. This allows Contour to have a `Valid` condition, that has further information about how that conditions `status` has been reached, or in other words, to expose more than one error or warning about a HTTPProxy to the user. Also adds the Conditions block to TLSCertificateDelegation. Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
add-httpproxy-conditions
branch
from
0bbee0b
to
a44ed82
Compare
Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
add-httpproxy-conditions
branch
from
a44ed82
to
1c68384
Compare
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
…our#2706) Updates projectcontour#2495. This adds a new `DetailedCondition` type to HTTPProxy, that allows for sub-conditions. This allows Contour to have a `Valid` condition, that has further information about how that conditions `status` has been reached, or in other words, to expose more than one error or warning about a HTTPProxy to the user. Also adds the Conditions block to TLSCertificateDelegation. Signed-off-by: Nick Young <ynick@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2495.
This adds a new
DetailedConditiontype to HTTPProxy, that allows for sub-conditions.This allows Contour to have a
Validcondition, that has further information abouthow that conditions
statushas been reached, or in other words, to expose morethan one error or warning about a HTTPProxy to the user.
Also adds the Conditions block to TLSCertificateDelegation.
Signed-off-by: Nick Young ynick@vmware.com