internal/contour: generate an Envoy secret for the fallback certificate #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the DAG visitor to emit an Envoy secret if the Contour fallback certificate is used by a secure virtual host. This fixes projectcontour#2720. Signed-off-by: James Peach <jpeach@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
==========================================
+ Coverage 76.88% 76.90% +0.01%
==========================================
Files 72 72
Lines 5711 5715 +4
==========================================
+ Hits 4391 4395 +4
Misses 1228 1228
Partials 92 92
|
|
this was pointed during the original PR review here: #2477 (comment) |
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
…te (projectcontour#2723) Update the DAG visitor to emit an Envoy secret if the Contour fallback certificate is used by a secure virtual host. This fixes projectcontour#2720. Signed-off-by: James Peach <jpeach@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the DAG visitor to emit an Envoy secret if the Contour fallback
certificate is used by a secure virtual host.
This fixes #2720.
Signed-off-by: James Peach jpeach@vmware.com