cmd/contour: refactor shutdown-manager to initiate shutdown using an Exec command #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
added
the
release-note
Codecov Report
@@ Coverage Diff @@
## master #2751 +/- ##
==========================================
- Coverage 77.02% 76.78% -0.25%
==========================================
Files 72 72
Lines 5719 5737 +18
==========================================
Hits 4405 4405
- Misses 1226 1244 +18
Partials 88 88
|
stevesloka
force-pushed
the
prestop
branch
3 times, most recently
from
910a541 to
e5ee5e1
Compare
…Exec command This changes the preStop lifecycle hook to utilize a command instead of an http request. The /shutdown http endpoint now only returns when the pod is ready to be terminated, and no longer initiates the Envoy shutdown sequence. The Envoy container will block on its preStop hook until the /shutdown endpoint returns. That endpoint, implemented in the shutdown-manager, will utilize a file messaging pattern to know when it is safe for Envoy to terminate by checking for the existence of a file in the filesystem. Signed-off-by: Steve Sloka <slokas@vmware.com>
skriss
reviewed
Jul 30, 2020
Signed-off-by: Steve Sloka <slokas@vmware.com>
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
…Exec command (projectcontour#2751) cmd/contour: refactor shutdown-manager to initiate shutdown using an Exec command This changes the preStop lifecycle hook to utilize a command instead of an http request. The /shutdown http endpoint now only returns when the pod is ready to be terminated, and no longer initiates the Envoy shutdown sequence. The Envoy container will block on its preStop hook until the /shutdown endpoint returns. That endpoint, implemented in the shutdown-manager, will utilize a file messaging pattern to know when it is safe for Envoy to terminate by checking for the existence of a file in the filesystem. Signed-off-by: Steve Sloka <slokas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the preStop lifecycle hook to utilize a command instead of an http request. The /shutdown http endpoint now only returns when the pod is ready to be terminated, and no longer initiates the Envoy shutdown sequence.
The Envoy container will block on its preStop hook until the /shutdown endpoint returns. That endpoint, implemented in the shutdown-manager, will utilize a file messaging pattern to know when it is safe for Envoy to terminate by checking for the existence of a file in the filesystem.
Signed-off-by: Steve Sloka slokas@vmware.com