docs: guides/cert-manager #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set correct `secretName` for resources related to `httpbinproxy`. Also set correct namespace for the dummy ingress object. Fixes #2800 Signed-off-by: Rajat Goyal <404rajat@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2804 +/- ##
==========================================
- Coverage 76.82% 76.78% -0.04%
==========================================
Files 73 73
Lines 5669 5669
==========================================
- Hits 4355 4353 -2
- Misses 1227 1228 +1
- Partials 87 88 +1
|
|
One of the integration tests is failing. Can someone please help me out here 🙏 |
|
Ah! It's passing now 🎉 |
|
I suspect it was a flaky test - it was the SNI check. I triggered a rerun and it seems to have passed now. |
youngnick
approved these changes
Aug 18, 2020
|
Thanks a lot for the quick review & merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct
secretNamefor resources related tohttpbinproxy.Also set correct namespace for the dummy ingress object.
Fixes #2800
Signed-off-by: Rajat Goyal 404rajat@gmail.com