Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/dag: upstream server cert validation for HTTP/2 #2832

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Aug 25, 2020

Fixes #2637.

Signed-off-by: Tero Saarni tero.saarni@est.tech

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #2832 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2832      +/-   ##
==========================================
+ Coverage   76.41%   76.45%   +0.03%     
==========================================
  Files          73       73              
  Lines        5703     5703              
==========================================
+ Hits         4358     4360       +2     
+ Misses       1259     1258       -1     
+ Partials       86       85       -1     
Impacted Files Coverage Δ
internal/dag/builder.go 92.22% <100.00%> (ø)
internal/dag/cache.go 97.56% <0.00%> (+0.81%) ⬆️

Fixes projectcontour#2637.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
@skriss skriss requested review from jpeach, skriss, youngnick and stevesloka and removed request for jpeach and skriss August 25, 2020 16:14
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tsaarni!

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngnick youngnick merged commit cd088b0 into projectcontour:main Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream peer validation is only available for the "tls" protocol.
3 participants