internal/dag: add support for ExternalService clusters #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft PR to pick up code coverage data. Still to do - add feature tests and fix debug logging. |
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
6a1e207 to
dda1a07
Compare
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
dda1a07 to
cc36128
Compare
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
cc36128 to
73e4066
Compare
Codecov Report
@@ Coverage Diff @@
## main #2876 +/- ##
==========================================
+ Coverage 75.61% 75.86% +0.25%
==========================================
Files 80 81 +1
Lines 5933 6025 +92
==========================================
+ Hits 4486 4571 +85
- Misses 1356 1361 +5
- Partials 91 93 +2
|
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
73e4066 to
53fb2ce
Compare
stevesloka
previously requested changes
Sep 3, 2020
There was a problem hiding this comment.
I'm not sure if you are ready for review or not @jpeach, your last comment was you were still working on tests, but I threw in some comments. =)
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
53fb2ce to
0ea5d8e
Compare
youngnick
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
LGTM, with a couple of small changes. I'd like to see @stevesloka's things addressed, either with code changes or comments too, please.
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
2 times, most recently
from
544416f to
03f6510
Compare
|
@stevesloka @youngnick Addressed all review feedback. |
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
2 times, most recently
from
102bacb to
d26c448
Compare
skriss
reviewed
Sep 8, 2020
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
d26c448 to
d949ef3
Compare
|
sorry, gave you a couple small merge conflicts to resolve |
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
d949ef3 to
f28ad9f
Compare
Refactor the ExtensionService `.Services` field so that we have enough information to build an EDS cluster load assignment. Dropping the use of the HTTPProxy `Service` type means that the API aligns more closely with the corresponding Envoy resources and we can build a single Envoy cluster that balances across all the configured Kubernetes services. This wasn't previously possible, since Envoy generally expects external services to be a single cluster and has no provision for balancing across multiple clusters in this part of its API. Add a new `dag.Processor` implementation to build ExtensionService objects in the DAG. These are root-level objects that generate Envoy cluster resources. The `.Services` field emits a `dag.ServiceCluster` object that generates an Envoy cluster load assignment resource to balance traffic within the cluster. This fixes projectcontour#2713. Signed-off-by: James Peach <jpeach@vmware.com>
jpeach
force-pushed
the
update-ExtensionServiceTarget
branch
from
f28ad9f to
649e315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the ExtensionService
.Servicesfield so that we have enoughinformation to build an EDS cluster load assignment. Dropping the use of
the HTTPProxy
Servicetype means that the API aligns more closely withthe corresponding Envoy resources and we can build a single Envoy cluster
that balances across all the configured Kubernetes services. This wasn't
previously possible, since Envoy generally expects external services to
be a single cluster and has no provision for balancing across multiple
clusters in this part of its API.
Add a new
dag.Processorimplementation to build ExtensionServiceobjects in the DAG. These are root-level objects that generate Envoy
cluster resources. The
.Servicesfield emits adag.ServiceClusterobject that generates an Envoy cluster load assignment resource to
balance traffic within the cluster.
This fixes #2713.
Signed-off-by: James Peach jpeach@vmware.com