Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/k8s: add ExtensionService to Kind helpers #2877

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Sep 3, 2020

Add ExtensionService to the builtin Kubernetes type helpers for accessing
the resource kind and version.

This updates #2713.

Signed-off-by: James Peach jpeach@vmware.com

Add ExtensionService to the builtin Kubernetes type helpers for accessing
the resource kind and version.

This updates projectcontour#2713.

Signed-off-by: James Peach <jpeach@vmware.com>
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #2877 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   76.79%   76.81%   +0.01%     
==========================================
  Files          77       77              
  Lines        5844     5848       +4     
==========================================
+ Hits         4488     4492       +4     
  Misses       1265     1265              
  Partials       91       91              
Impacted Files Coverage Δ
internal/k8s/kind.go 54.54% <100.00%> (+4.54%) ⬆️

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka stevesloka merged commit b92f169 into projectcontour:main Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants