apis: add kubebuilder regex validation for timeout strings #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 76.33% 76.30% -0.04%
==========================================
Files 83 83
Lines 6344 6344
==========================================
- Hits 4843 4841 -2
- Misses 1407 1408 +1
- Partials 94 95 +1
|
skriss
added
the
release-note
stevesloka
approved these changes
Sep 16, 2020
Yep, good idea. Still need to wrap my brain around how to add new test cases there as I haven't done it yet. |
skriss
force-pushed
the
timeout-regex-validations
branch
2 times, most recently
from
406ebe3 to
fc20477
Compare
|
@stevesloka I'll file a followup issue to look at adding an integration test for this. |
Adds kubebuilder regex validations for all timeout string API fields. Closes projectcontour#2728 Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
timeout-regex-validations
branch
from
fc20477 to
9479e63
Compare
|
ignoring SNI integration test flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds kubebuilder regex validations for all timeout string API
fields.
Closes #2728
Signed-off-by: Steve Kriss krisss@vmware.com