Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/contour: log warning for HTTPProxies/Ingresses using TLS 1.1 #3012

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

skriss
Copy link
Member

@skriss skriss commented Oct 8, 2020

Logs warnings on server startup for HTTPProxies and Ingresses using
a TLS minimum protocol version of 1.1 without also having the config
file's tls.minimum-protocol-version set to 1.1, since the default
value for the config file field will change to 1.2 in an upcoming
release.

Updates #2777.

Signed-off-by: Steve Kriss krisss@vmware.com

Logs warnings on server startup for HTTPProxies and Ingresses using
a TLS minimum protocol version of 1.1 without also having the config
file's tls.minimum-protocol-version set to 1.1, since the default
value for the config file field will change to 1.2 in an upcoming
release.

Updates projectcontour#2777.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #3012 into main will decrease coverage by 0.50%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
- Coverage   74.98%   74.47%   -0.51%     
==========================================
  Files          92       92              
  Lines        5920     5960      +40     
==========================================
  Hits         4439     4439              
- Misses       1383     1423      +40     
  Partials       98       98              
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skriss skriss merged commit 0e255a8 into projectcontour:main Oct 9, 2020
@skriss skriss deleted the warn-tls-global-min-changing branch October 9, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants