deployment: Update rbac versions from v1beta1 to v1 #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the apiVersions of resources in rbac group such as ClusterRoleBinding, Role etc. to v1 version from v1beta1 as it's deprecated since kubernetes 1.17 version and will be removed in 1.22 version. Fixes projectcontour#2991 Signed-off-by: hnarahari <hnarahari@vmware.com>
|
I've tested with k8s versions 1.16.1 and 1.19.1 in kind cluster and rbac resources get created with v1 version in both. |
Codecov Report
@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 74.98% 74.98%
=======================================
Files 92 92
Lines 5920 5920
=======================================
Hits 4439 4439
Misses 1383 1383
Partials 98 98 |
skriss
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
This LGTM, thanks @narahari92!
FYI, the integration test failure is a known test flake.
|
Thank you @skriss. I was confused why a test was failing for this change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the apiVersions of resources in rbac group such as ClusterRoleBinding, Role etc. to
v1 version from v1beta1 as it's deprecated since kubernetes 1.17 version and will be removed
in 1.22 version.
Fixes #2991
Signed-off-by: hnarahari hnarahari@vmware.com