-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/xds: xDS v3 server implementation #3017
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
- Coverage 74.30% 74.00% -0.30%
==========================================
Files 92 95 +3
Lines 6008 6081 +73
==========================================
+ Hits 4464 4500 +36
- Misses 1446 1479 +33
- Partials 98 102 +4
|
2abdf6c
to
4014198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to duplicate all the code here? The only think that is really different is the types of the discovery request and response. Can we take an approach where we only have to duplicate or abstract the guts of (*contourServer)stream()
?
56ab109
to
9fa871e
Compare
It seems like in order to reuse much more code here, we'd need to define some interfaces and wrapper structs to adapt the v2 & v3 discovery request and response structs to common interfaces that the Given that we're looking to replace this all with the go-control-plane xds server though, I'm not sure it's really worth spending that effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits but overall I'm fine with this as-is, given that (1) we're going to drop v2 support pretty soon since it will be removed from Envoy early next year; (2) we're in the process of moving exclusively to the go-control-plane impl; and (3) upstream Envoy will not be revving a major version of the API every year going fwd.
Adds a v3 xDS server which can be used to serve Envoy xDS v3 apis. Updates projectcontour#1898 Signed-off-by: Steve Sloka <slokas@vmware.com>
98bbd58
to
960b673
Compare
Follows #3016 by adding an xDS v3 server. Follow-up PR will introduce a config option to specify the xDS version wanting to serve.
Updates #1898