Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Envoy to v1.16.0 #3029

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Update Envoy to v1.16.0 #3029

merged 2 commits into from
Oct 14, 2020

Conversation

yoitsro
Copy link
Contributor

@yoitsro yoitsro commented Oct 14, 2020 •
edited by skriss
Loading

This PR updates Makefile to use the latest version of Envoy (v1.16.0).

It also updates the examples to reflect this change.

Fixes #3013

@yoitsro yoitsro force-pushed the chore/upgrade-envoy branch from abcd6ef to 77b1f46 Compare October 14, 2020 12:27
@yoitsro yoitsro mentioned this pull request Oct 14, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #3029 into main will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
- Coverage   74.52%   74.49%   -0.04%     
==========================================
  Files          92       92              
  Lines        5963     5963              
==========================================
- Hits         4444     4442       -2     
- Misses       1422     1423       +1     
- Partials       97       98       +1
Impacted Files Coverage Δ
internal/dag/cache.go 95.36% <0.00%> (-0.78%) ⬇️

@yoitsro
makefile: update Envoy to v1.16.0
c46c3cd 
Closes projectcontour#3013

Signed-off-by: Ro Ramtohul <yoitsro@hotmail.com>
@yoitsro
examples: update Envoy to v1.16.0
1e7a9fb 
Contributes to projectcontour#3013

Signed-off-by: Ro Ramtohul <yoitsro@hotmail.com>
@yoitsro yoitsro force-pushed the chore/upgrade-envoy branch from 77b1f46 to 1e7a9fb Compare October 14, 2020 12:51
skriss
skriss approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoitsro, LGTM. I ran a basic smoke-test and didn't see any issues.

@skriss skriss requested a review from stevesloka October 14, 2020 14:55
stevesloka
stevesloka approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevesloka
Copy link
Member

Thanks @yoitsro! 🎉

@stevesloka stevesloka added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 14, 2020
@stevesloka stevesloka added this to the 1.10.0 milestone Oct 14, 2020
@stevesloka stevesloka merged commit 9d7aa17 into projectcontour:main Oct 14, 2020
@yoitsro yoitsro deleted the chore/upgrade-envoy branch October 14, 2020 16:14
@skriss skriss mentioned this pull request Oct 19, 2020
Merged
@moderation moderation mentioned this pull request Oct 21, 2020
Closed
@skriss skriss mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@stevesloka stevesloka stevesloka approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Upgrade to Envoy v1.16
3 participants
@yoitsro @stevesloka @skriss