apis: Add detail subcondition type to DetailedCondition #3134
+444
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
added
the
release-note
|
Need thoughts on naming from comments in #2495 (comment). |
Codecov Report
@@ Coverage Diff @@
## main #3134 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 96 96
Lines 6004 6004
=======================================
Hits 4449 4449
Misses 1457 1457
Partials 98 98 |
Adds a details subcodition array to the DetailedCondition allowing for more information to be exposed to users via an HTTPProxy Conditions struct. Things like fqdn, included paths or headers can be written to child proxies allowing users to understand what has been included to them from a parent resource. Updates projectcontour#2495 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
proxyFqdnStatus
branch
from
b444690
to
4f785d4
Compare
|
No description provided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a details subcodition array to the DetailedCondition allowing
for more information to be exposed to users via an HTTPProxy
Conditions struct. Things like fqdn, included paths or headers
can be written to child proxies allowing users to understand
what has been included to them from a parent resource.
Updates #2495
Signed-off-by: Steve Sloka slokas@vmware.com