Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: update cert-manager guide #4115

Merged
merged 3 commits into from
Oct 16, 2021

Conversation

skriss
Copy link
Member

@skriss skriss commented Oct 14, 2021

Updates the cert-manager guide to use the
newest versions of Contour and cert-manager.
Also updates to use Ingress v1.

Closes #4095.

Signed-off-by: Steve Kriss krisss@vmware.com

@skriss skriss requested a review from a team as a code owner October 14, 2021 17:00
@skriss skriss requested review from sunjayBhatia and youngnick and removed request for a team October 14, 2021 17:00
@skriss skriss added the release-note/docs A documentation change for the release notes. label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #4115 (e6d1215) into main (bbbef2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4115   +/-   ##
=======================================
  Coverage   74.54%   74.54%           
=======================================
  Files         112      112           
  Lines        9687     9687           
=======================================
  Hits         7221     7221           
  Misses       2308     2308           
  Partials      158      158           

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (disclaimer didn't do the whole setup as its pretty similar to the original)

(one tiny nit, can't comment on since its not a diff, but theres a reference to the year 2020 in the Bonus points section which we could maybe remove)

Updates the cert-manager guide to use the
newest versions of Contour and cert-manager.
Also updates to use Ingress v1.

Closes projectcontour#4095.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the cert-manager-guide-refresh branch from 78125b4 to e6d1215 Compare October 15, 2021 22:19
@skriss skriss merged commit 1442771 into projectcontour:main Oct 16, 2021
@skriss skriss deleted the cert-manager-guide-refresh branch October 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refresh contour + cert-manager guide
3 participants