Fix negated allow chunked length field #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes out NewListenerConfig constructor, back to using a struct Pulls out parts of that into pkg/config validation and new package we can use for contourconfiguration crd helpers Still TODO: we need to do a bigger refactor of how we wire up the xds server, xdscache components, informers etc., leaving testing of the contents of cmd/contour to that change Fixes: projectcontour#4140 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
requested review from
tsaarni and
youngnick
and removed request for
a team
sunjayBhatia
added
the
release-note/small
Codecov Report
@@ Coverage Diff @@
## main #4152 +/- ##
==========================================
+ Coverage 73.16% 73.70% +0.53%
==========================================
Files 113 114 +1
Lines 9884 9867 -17
==========================================
+ Hits 7232 7272 +40
+ Misses 2498 2441 -57
Partials 154 154
|
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
Nov 4, 2021
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
youngnick
approved these changes
Nov 4, 2021
|
has some conflicts to resolve before merge. |
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes out NewListenerConfig constructor, back to using a struct
Pulls out parts of that into pkg/config validation and new package we
can use for contourconfiguration crd helpers
Still TODO: we need to do a bigger refactor of how we wire up the xds
server, xdscache components, informers etc., leaving testing of the
contents of cmd/contour to that change
Fixes: #4140