drop TCPRoute/UDPRoute controllers and RBAC #4166
Conversation
skriss
requested review from
tsaarni and
stevesloka
and removed request for
a team
skriss
added
the
release-note/small
|
One note here, the example manifests do still create the TCPRoute/UDPRoute CRDs, since we're just pulling directly from the Gateway API repo. This seems OK to me, but we could also add a script to remove them from the YAML entirely. |
With this PR, Contour no longer watches TCPRoutes or UDPRoutes, and does not set an "Accepted: false" condition on them. All RBAC related to them is dropped as well. Closes projectcontour#4156. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
rm-tcproute-udproute
branch
from
0927509 to
4b59e9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #4166 +/- ##
==========================================
+ Coverage 73.16% 75.11% +1.95%
==========================================
Files 113 110 -3
Lines 9884 9630 -254
==========================================
+ Hits 7232 7234 +2
+ Misses 2498 2242 -256
Partials 154 154
|
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package controller |
There was a problem hiding this comment.
Has this file been removed because we're not using it any more? How are the conditions for Gateway etc being set again?
There was a problem hiding this comment.
Yeah, not using it anymore -- I created this file when I added the TCPRoute/UDPRoute controllers to share some logic between them. Logic for setting GatewayClass/Gateway conditions are in the respective controllers, or in the DAG.
With this PR, Contour no longer watches
TCPRoutes or UDPRoutes, and does not set
an "Accepted: false" condition on them.
All RBAC related to them is dropped as well.
Closes #4156.
Signed-off-by: Steve Kriss krisss@vmware.com