Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #4167

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix typo #4167

merged 1 commit into from
Nov 10, 2021

Conversation

lewislbr
Copy link
Contributor

@lewislbr lewislbr commented Nov 9, 2021

The quickstart has three steps:

  1. Set up a kubernetes environment
  2. Install a Contour service
  3. Install a kuard workload

On step 1, there is the option to skip to "Install a Contour service", which is the step 2, but is referred to as 3.

@lewislbr lewislbr requested a review from a team as a code owner November 9, 2021 18:11
@lewislbr lewislbr requested review from tsaarni and skriss and removed request for a team November 9, 2021 18:11
Signed-off-by: Lewis Llobera <billobera@gmail.com>
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #4167 (e645cd6) into main (6d78450) will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4167      +/-   ##
==========================================
+ Coverage   73.16%   73.71%   +0.54%     
==========================================
  Files         113      114       +1     
  Lines        9884     9867      -17     
==========================================
+ Hits         7232     7273      +41     
+ Misses       2498     2440      -58     
  Partials      154      154              
Impacted Files Coverage Δ
cmd/contour/serve.go 12.44% <0.00%> (-0.47%) ⬇️
internal/contourconfig/contourconfiguration.go 100.00% <0.00%> (ø)
pkg/config/parameters.go 92.03% <0.00%> (+0.26%) ⬆️
internal/sorter/sorter.go 98.78% <0.00%> (+1.21%) ⬆️
internal/xdscache/v3/listener.go 90.53% <0.00%> (+21.13%) ⬆️

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @lewislbr!

@youngnick youngnick merged commit cb3ae35 into projectcontour:main Nov 10, 2021
@youngnick youngnick added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants