internal/dag: apply TCPProxy service weights #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where HTTPProxy TCPProxy service weights were not being applied. Closes projectcontour#4158. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
tsaarni and
youngnick
and removed request for
a team
skriss
added
the
release-note/small
skriss
added
release-note/minor
Codecov Report
@@ Coverage Diff @@
## main #4169 +/- ##
==========================================
+ Coverage 73.71% 73.76% +0.05%
==========================================
Files 114 114
Lines 9867 9887 +20
==========================================
+ Hits 7273 7293 +20
Misses 2440 2440
Partials 154 154
|
Signed-off-by: Steve Kriss <krisss@vmware.com>
youngnick
approved these changes
Nov 10, 2021
sunjayBhatia
approved these changes
Nov 11, 2021
skriss
added a commit
to skriss/contour
that referenced
this pull request
Nov 11, 2021
Fixes some logical merge conflicts in the tests from projectcontour#4169. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added a commit
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where HTTPProxy TCPProxy service
weights were not being applied.
Closes #4158.
Signed-off-by: Steve Kriss krisss@vmware.com