Simplify regex path match to reduce program size #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ingress/HTTPRoute prefix matches now have an anchor to ensure long prefixes don't increase the program size. Should ensure they are not rejected by Envoy. In addition, add an anchor to regex path matches since they at least have to start with a literal / Updates: projectcontour#4191 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
added
the
release-note/small
Codecov Report
@@ Coverage Diff @@
## main #4197 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 111 111
Lines 9785 9785
=======================================
Hits 7436 7436
Misses 2181 2181
Partials 168 168
|
youngnick
approved these changes
Nov 25, 2021
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
Dec 6, 2021
yeah, need to get those running in CI but theyre pretty flaky as-is, need to add some retries to the requests or something similar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingress/HTTPRoute prefix matches now have an anchor to ensure long
prefixes don't increase the program size. Should ensure they are not
rejected by Envoy.
In addition, add an anchor to regex path matches since they at least
have to start with a literal /
Manually ran ingress conformance tests and besides flakes, all passed 👍🏽
Updates: #4191