Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/config: Remove leader election configuration #4340

Merged
merged 2 commits into from
Feb 11, 2022
Merged

pkg/config: Remove leader election configuration #4340

merged 2 commits into from
Feb 11, 2022

Conversation

sunjayBhatia
Copy link
Member

Leader election configuration via configuration file was deprecated in Contour
v1.20.0. Configuration should be done via command line parameters only.

@sunjayBhatia
pkg/config: Remove leader election configuration
ca7267b 
Leader election configuration via configuration file was deprecated in Contour
v1.20.0. Configuration should be done via command line parameters only.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. label Feb 11, 2022
@sunjayBhatia sunjayBhatia added this to the 1.21.0 milestone Feb 11, 2022
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner February 11, 2022 19:42
@sunjayBhatia sunjayBhatia requested review from tsaarni and stevesloka and removed request for a team February 11, 2022 19:42
@sunjayBhatia
changelog
1162e8f 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@codecov
Copy link

codecov bot commented Feb 11, 2022 •
edited
Loading

Codecov Report

Merging #4340 (1162e8f) into main (6018bf5) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4340      +/-   ##
==========================================
- Coverage   78.29%   78.27%   -0.02%     
==========================================
  Files         112      112              
  Lines       10035    10027       -8     
==========================================
- Hits         7857     7849       -8     
  Misses       1998     1998              
  Partials      180      180
Impacted Files Coverage Δ
cmd/contour/serve.go 12.57% <0.00%> (ø)
pkg/config/parameters.go 91.47% <ø> (-0.23%) ⬇️
cmd/contour/servecontext.go 83.44% <100.00%> (-0.06%) ⬇️

skriss
skriss approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 and deprecation label lookin' good!

@sunjayBhatia sunjayBhatia merged commit 3498b96 into projectcontour:main Feb 11, 2022
@sunjayBhatia sunjayBhatia deleted the remove-leaderelection-config-file branch February 11, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sunjayBhatia @skriss