Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base RTDS implementation #4380

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

sunjayBhatia
Copy link
Member

Part of gradual implementation of RTDS, first step to allow configurable
runtime values. Returns an empty set of Runtime layers (instead of just
returning unimplemented to avoid issues in future upgrades). Next step
will be to add ability to dynamically fetch Runtime layer in bootstrap.

Updates: #3452

Part of gradual implementation of RTDS, first step to allow configurable
runtime values. Returns an empty set of Runtime layers (instead of just
returning unimplemented to avoid issues in future upgrades). Next step
will be to add ability to dynamically fetch Runtime layer in bootstrap.

Updates: projectcontour#3452

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner February 28, 2022 19:25
@sunjayBhatia sunjayBhatia requested review from stevesloka and youngnick and removed request for a team February 28, 2022 19:25
@sunjayBhatia sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label Feb 28, 2022
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4380 (83f6c4d) into main (8c9bc6c) will increase coverage by 0.00%.
The diff coverage is 63.63%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4380   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files         112      113    +1     
  Lines       10127    10138   +11     
=======================================
+ Hits         7934     7943    +9     
- Misses       2011     2013    +2     
  Partials      182      182           
Impacted Files Coverage Δ
cmd/contour/serve.go 12.96% <0.00%> (-0.03%) ⬇️
internal/xdscache/snapshot.go 11.36% <0.00%> (-0.27%) ⬇️
internal/xdscache/v3/runtime.go 66.66% <66.66%> (ø)
internal/xds/v3/contour.go 96.77% <100.00%> (+0.10%) ⬆️
internal/xds/v3/server.go 100.00% <100.00%> (ø)
internal/sorter/sorter.go 98.78% <0.00%> (+1.21%) ⬆️

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunjayBhatia
Copy link
Member Author

unrelated osx flake

@sunjayBhatia sunjayBhatia merged commit ff31adc into projectcontour:main Mar 2, 2022
@sunjayBhatia sunjayBhatia deleted the rtds-endpoints branch March 2, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants